Discussion:
[PATCH] drivers/base: use a worker for sysfs unbind
(too old to reply)
Daniel Vetter
2018-12-07 09:31:33 UTC
Permalink
Drivers might want to remove some sysfs files, which needs the same
locks and ends up angering lockdep. Relevant snippet of the stack
trace:

kernfs_remove_by_name_ns+0x3b/0x80
bus_remove_driver+0x92/0xa0
acpi_video_unregister+0x24/0x40
i915_driver_unload+0x42/0x130 [i915]
i915_pci_remove+0x19/0x30 [i915]
pci_device_remove+0x36/0xb0
device_release_driver_internal+0x185/0x250
unbind_store+0xaf/0x180
kernfs_fop_write+0x104/0x190

I've stumbled over this because some new patches by Ram connect the
snd-hda-intel unload (where we do use sysfs unbind) with the locking
chains in the i915 unload code (but without creating a new loop),
which upset our CI. But the bug is already there and can be easily
reproduced by unbind i915 directly.

No idea whether this is the correct place to fix this, should at least
get CI happy again.

Cc: Ramalingam C <***@intel.com>
Signed-off-by: Daniel Vetter <***@intel.com>
---
drivers/base/bus.c | 33 +++++++++++++++++++++++++++------
1 file changed, 27 insertions(+), 6 deletions(-)

diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 8bfd27ec73d6..864412df86a9 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -174,22 +174,43 @@ static const struct kset_uevent_ops bus_uevent_ops = {

static struct kset *bus_kset;

+struct unbind_work {
+ struct work_struct work;
+ struct device *dev;
+};
+
+void unbind_work_fn(struct work_struct *work)
+{
+ struct unbind_work *unbind_work =
+ container_of(work, struct unbind_work, work);
+
+ device_release_driver(unbind_work->dev);
+ put_device(unbind_work->dev);
+}
+
/* Manually detach a device from its associated driver. */
static ssize_t unbind_store(struct device_driver *drv, const char *buf,
size_t count)
{
struct bus_type *bus = bus_get(drv->bus);
+ struct unbind_work *unbind_work;
struct device *dev;
int err = -ENODEV;

dev = bus_find_device_by_name(bus, NULL, buf);
if (dev && dev->driver == drv) {
- if (dev->parent && dev->bus->need_parent_lock)
- device_lock(dev->parent);
- device_release_driver(dev);
- if (dev->parent && dev->bus->need_parent_lock)
- device_unlock(dev->parent);
- err = count;
+ unbind_work = kmalloc(sizeof(*unbind_work), GFP_KERNEL);
+ if (unbind_work) {
+ unbind_work->dev = dev;
+ get_device(dev);
+ INIT_WORK(&unbind_work->work, unbind_work_fn);
+
+ schedule_work(&unbind_work->work);
+
+ err = count;
+ } else {
+ err = -ENOMEM;
+ }
}
put_device(dev);
bus_put(bus);
--
2.20.0.rc1
Chris Wilson
2018-12-07 09:58:06 UTC
Permalink
Quoting Daniel Vetter (2018-12-07 09:31:33)
Post by Daniel Vetter
+void unbind_work_fn(struct work_struct *work)
+{
+ struct unbind_work *unbind_work =
+ container_of(work, struct unbind_work, work);
+
+ device_release_driver(unbind_work->dev);
+ put_device(unbind_work->dev);
+}
+
/* Manually detach a device from its associated driver. */
static ssize_t unbind_store(struct device_driver *drv, const char *buf,
size_t count)
{
struct bus_type *bus = bus_get(drv->bus);
+ struct unbind_work *unbind_work;
struct device *dev;
int err = -ENODEV;
dev = bus_find_device_by_name(bus, NULL, buf);
if (dev && dev->driver == drv) {
- if (dev->parent && dev->bus->need_parent_lock)
- device_lock(dev->parent);
Do we not need to keep this locking in the worker?
-Chris
Daniel Vetter
2018-12-07 11:00:17 UTC
Permalink
Post by Chris Wilson
Quoting Daniel Vetter (2018-12-07 09:31:33)
Post by Daniel Vetter
+void unbind_work_fn(struct work_struct *work)
+{
+ struct unbind_work *unbind_work =
+ container_of(work, struct unbind_work, work);
+
+ device_release_driver(unbind_work->dev);
+ put_device(unbind_work->dev);
+}
+
/* Manually detach a device from its associated driver. */
static ssize_t unbind_store(struct device_driver *drv, const char *buf,
size_t count)
{
struct bus_type *bus = bus_get(drv->bus);
+ struct unbind_work *unbind_work;
struct device *dev;
int err = -ENODEV;
dev = bus_find_device_by_name(bus, NULL, buf);
if (dev && dev->driver == drv) {
- if (dev->parent && dev->bus->need_parent_lock)
- device_lock(dev->parent);
Do we not need to keep this locking in the worker?
Ah forgot to mention that in the commit message: This locking is already
done in device_release_driver -> device_release_driver_internal. I'll fix
up the commit message, thanks for the reminder.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Patchwork
2018-12-07 11:51:00 UTC
Permalink
== Series Details ==

Series: drivers/base: use a worker for sysfs unbind
URL : https://patchwork.freedesktop.org/series/53734/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
57258bb87944 drivers/base: use a worker for sysfs unbind
-:85: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <***@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 49 lines checked
Patchwork
2018-12-07 12:15:14 UTC
Permalink
== Series Details ==

Series: drivers/base: use a worker for sysfs unbind
URL : https://patchwork.freedesktop.org/series/53734/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5282 -> Patchwork_11046
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_11046 absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_11046, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53734/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_11046:

### IGT changes ###

#### Possible regressions ####

* ***@i915_module_load@reload-no-display:
- fi-skl-6700hq: PASS -> INCOMPLETE
- fi-skl-6700k2: PASS -> INCOMPLETE
- fi-skl-iommu: PASS -> INCOMPLETE
- fi-kbl-7560u: PASS -> INCOMPLETE
- fi-pnv-d510: PASS -> INCOMPLETE
- fi-whl-u: PASS -> INCOMPLETE
- fi-bwr-2160: PASS -> INCOMPLETE
- fi-kbl-r: PASS -> INCOMPLETE
- {fi-kbl-7567u}: PASS -> INCOMPLETE
- fi-skl-6260u: PASS -> INCOMPLETE
- fi-snb-2600: PASS -> INCOMPLETE
- fi-hsw-peppy: PASS -> INCOMPLETE
- fi-ilk-650: PASS -> INCOMPLETE
- fi-skl-6770hq: PASS -> INCOMPLETE
- fi-cfl-guc: PASS -> INCOMPLETE
- fi-ivb-3770: PASS -> INCOMPLETE
- fi-snb-2520m: PASS -> INCOMPLETE
- fi-cfl-8700k: PASS -> INCOMPLETE
- {fi-kbl-7500u}: PASS -> INCOMPLETE
- fi-ivb-3520m: PASS -> INCOMPLETE
- fi-hsw-4770: PASS -> INCOMPLETE
- fi-kbl-guc: PASS -> INCOMPLETE
- fi-skl-guc: PASS -> INCOMPLETE
- fi-bdw-5557u: PASS -> INCOMPLETE
- fi-cfl-8109u: PASS -> INCOMPLETE
- fi-hsw-4770r: PASS -> INCOMPLETE

* {***@runner@aborted}:
- fi-ilk-650: NOTRUN -> FAIL
- fi-pnv-d510: NOTRUN -> FAIL
- fi-hsw-peppy: NOTRUN -> FAIL
- fi-glk-dsi: NOTRUN -> FAIL
- fi-hsw-4770: NOTRUN -> FAIL
- fi-bxt-j4205: NOTRUN -> FAIL
- fi-skl-6700hq: NOTRUN -> FAIL
- fi-whl-u: NOTRUN -> FAIL
- fi-ivb-3770: NOTRUN -> FAIL
- fi-kbl-7560u: NOTRUN -> FAIL
- fi-bxt-dsi: NOTRUN -> FAIL
- fi-byt-j1900: NOTRUN -> FAIL
- fi-skl-iommu: NOTRUN -> FAIL
- fi-cfl-guc: NOTRUN -> FAIL
- fi-glk-j4005: NOTRUN -> FAIL
- fi-skl-guc: NOTRUN -> FAIL
- fi-bsw-n3050: NOTRUN -> FAIL
- fi-cfl-8700k: NOTRUN -> FAIL
- fi-hsw-4770r: NOTRUN -> FAIL
- fi-skl-6600u: NOTRUN -> FAIL
- fi-kbl-8809g: NOTRUN -> FAIL
- fi-apl-guc: NOTRUN -> FAIL
- fi-kbl-r: NOTRUN -> FAIL
- fi-bdw-5557u: NOTRUN -> FAIL
- fi-bwr-2160: NOTRUN -> FAIL
- fi-byt-n2820: NOTRUN -> FAIL
- fi-skl-6770hq: NOTRUN -> FAIL
- fi-ivb-3520m: NOTRUN -> FAIL
- fi-snb-2600: NOTRUN -> FAIL
- fi-skl-6260u: NOTRUN -> FAIL


Known issues
------------

Here are the changes found in Patchwork_11046 that come from known issues:

### IGT changes ###

#### Issues hit ####

* ***@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* ***@i915_module_load@reload-no-display:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927]
- fi-byt-j1900: PASS -> INCOMPLETE [fdo#102657]
- fi-skl-6600u: PASS -> INCOMPLETE [fdo#104108]
- fi-kbl-8809g: PASS -> INCOMPLETE [fdo#103665]
- fi-glk-j4005: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
- fi-bsw-n3050: PASS -> INCOMPLETE [fdo#105876]
- fi-byt-n2820: PASS -> INCOMPLETE [fdo#102657]
- fi-bxt-j4205: PASS -> INCOMPLETE [fdo#103927]
- fi-bxt-dsi: PASS -> INCOMPLETE [fdo#103927]
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]

* ***@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]


{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (51 -> 45)
------------------------------

Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600


Build changes
-------------

* Linux: CI_DRM_5282 -> Patchwork_11046

CI_DRM_5282: d63c50f2b014037b43c1c0f108c61e0a31ede3c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4743: edb2db2cf2b6665d7ba3fa9117263302f6307a4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11046: 57258bb87944c30d0d48b6ab83a477e0562b89f2 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

57258bb87944 drivers/base: use a worker for sysfs unbind

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11046/
Chris Wilson
2018-12-07 12:24:39 UTC
Permalink
Quoting Patchwork (2018-12-07 12:15:14)
Post by Patchwork
== Series Details ==
Series: drivers/base: use a worker for sysfs unbind
URL : https://patchwork.freedesktop.org/series/53734/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5282 -> Patchwork_11046
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_11046 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_11046, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53734/revisions/1/mbox/
Possible new issues
-------------------
### IGT changes ###
#### Possible regressions ####
- fi-skl-6700hq: PASS -> INCOMPLETE
Do we need to hold a reference to the entire driver tree? Or perhaps an
ordered wq.
-Chris
Daniel Vetter
2018-12-07 16:01:26 UTC
Permalink
Drivers might want to remove some sysfs files, which needs the same
locks and ends up angering lockdep. Relevant snippet of the stack
trace:

kernfs_remove_by_name_ns+0x3b/0x80
bus_remove_driver+0x92/0xa0
acpi_video_unregister+0x24/0x40
i915_driver_unload+0x42/0x130 [i915]
i915_pci_remove+0x19/0x30 [i915]
pci_device_remove+0x36/0xb0
device_release_driver_internal+0x185/0x250
unbind_store+0xaf/0x180
kernfs_fop_write+0x104/0x190

I've stumbled over this because some new patches by Ram connect the
snd-hda-intel unload (where we do use sysfs unbind) with the locking
chains in the i915 unload code (but without creating a new loop),
which upset our CI. But the bug is already there and can be easily
reproduced by unbind i915 directly.

No idea whether this is the correct place to fix this, should at least
get CI happy again.

Note that the bus locking is already done by device_release_driver ->
device_release_driver_internal, so I dropped that part. Also note that
we don't recheck that the device is still bound by the same driver,
but neither does the current code do that without races. And I figured
that's a obscure enough corner case to not bother.

Cc: Ramalingam C <***@intel.com>
Signed-off-by: Daniel Vetter <***@intel.com>
---
drivers/base/bus.c | 35 +++++++++++++++++++++++++++++------
1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 8bfd27ec73d6..2cc18545918a 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -174,22 +174,45 @@ static const struct kset_uevent_ops bus_uevent_ops = {

static struct kset *bus_kset;

+struct unbind_work {
+ struct work_struct work;
+ struct device *dev;
+};
+
+void unbind_work_fn(struct work_struct *work)
+{
+ struct unbind_work *unbind_work =
+ container_of(work, struct unbind_work, work);
+
+ device_release_driver_internal(unbind_work->dev, NULL,
+ unbind_work->dev->parent);
+ put_device(unbind_work->dev);
+ kfree(unbind_work);
+}
+
/* Manually detach a device from its associated driver. */
static ssize_t unbind_store(struct device_driver *drv, const char *buf,
size_t count)
{
struct bus_type *bus = bus_get(drv->bus);
+ struct unbind_work *unbind_work;
struct device *dev;
int err = -ENODEV;

dev = bus_find_device_by_name(bus, NULL, buf);
if (dev && dev->driver == drv) {
- if (dev->parent && dev->bus->need_parent_lock)
- device_lock(dev->parent);
- device_release_driver(dev);
- if (dev->parent && dev->bus->need_parent_lock)
- device_unlock(dev->parent);
- err = count;
+ unbind_work = kmalloc(sizeof(*unbind_work), GFP_KERNEL);
+ if (unbind_work) {
+ unbind_work->dev = dev;
+ get_device(dev);
+ INIT_WORK(&unbind_work->work, unbind_work_fn);
+
+ schedule_work(&unbind_work->work);
+
+ err = count;
+ } else {
+ err = -ENOMEM;
+ }
}
put_device(dev);
bus_put(bus);
--
2.20.0.rc1
Daniel Vetter
2018-12-09 17:20:02 UTC
Permalink
Drivers might want to remove some sysfs files, which needs the same
locks and ends up angering lockdep. Relevant snippet of the stack
trace:

kernfs_remove_by_name_ns+0x3b/0x80
bus_remove_driver+0x92/0xa0
acpi_video_unregister+0x24/0x40
i915_driver_unload+0x42/0x130 [i915]
i915_pci_remove+0x19/0x30 [i915]
pci_device_remove+0x36/0xb0
device_release_driver_internal+0x185/0x250
unbind_store+0xaf/0x180
kernfs_fop_write+0x104/0x190

I've stumbled over this because some new patches by Ram connect the
snd-hda-intel unload (where we do use sysfs unbind) with the locking
chains in the i915 unload code (but without creating a new loop),
which upset our CI. But the bug is already there and can be easily
reproduced by unbind i915 directly.

No idea whether this is the correct place to fix this, should at least
get CI happy again.

Note that the bus locking is already done by device_release_driver ->
device_release_driver_internal, so I dropped that part. Also note that
we don't recheck that the device is still bound by the same driver,
but neither does the current code do that without races. And I figured
that's a obscure enough corner case to not bother.

v2: Use a task work. An entirely async work leads to impressive
fireworks in our CI, notably in the vtcon bind/unbind code. Task work
will be as synchronous as the current code, and so keep all these
preexisting races neatly tugged under the rug.

Cc: Ramalingam C <***@intel.com>
Signed-off-by: Daniel Vetter <***@intel.com>
---
drivers/base/bus.c | 35 +++++++++++++++++++++++++++++------
1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 8bfd27ec73d6..095c4a140d76 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -17,6 +17,7 @@
#include <linux/string.h>
#include <linux/mutex.h>
#include <linux/sysfs.h>
+#include <linux/task_work.h>
#include "base.h"
#include "power/power.h"

@@ -174,22 +175,44 @@ static const struct kset_uevent_ops bus_uevent_ops = {

static struct kset *bus_kset;

+struct unbind_work {
+ struct callback_head twork;
+ struct device *dev;
+};
+
+void unbind_work_fn(struct callback_head *work)
+{
+ struct unbind_work *unbind_work =
+ container_of(work, struct unbind_work, twork);
+
+ device_release_driver_internal(unbind_work->dev, NULL,
+ unbind_work->dev->parent);
+ put_device(unbind_work->dev);
+ kfree(unbind_work);
+}
+
/* Manually detach a device from its associated driver. */
static ssize_t unbind_store(struct device_driver *drv, const char *buf,
size_t count)
{
struct bus_type *bus = bus_get(drv->bus);
+ struct unbind_work *unbind_work;
struct device *dev;
int err = -ENODEV;

dev = bus_find_device_by_name(bus, NULL, buf);
if (dev && dev->driver == drv) {
- if (dev->parent && dev->bus->need_parent_lock)
- device_lock(dev->parent);
- device_release_driver(dev);
- if (dev->parent && dev->bus->need_parent_lock)
- device_unlock(dev->parent);
- err = count;
+ unbind_work = kmalloc(sizeof(*unbind_work), GFP_KERNEL);
+ if (unbind_work) {
+ unbind_work->dev = dev;
+ get_device(dev);
+ init_task_work(&unbind_work->twork, unbind_work_fn);
+ task_work_add(current, &unbind_work->twork, true);
+
+ err = count;
+ } else {
+ err = -ENOMEM;
+ }
}
put_device(dev);
bus_put(bus);
--
2.20.0.rc1
Patchwork
2018-12-07 17:12:57 UTC
Permalink
== Series Details ==

Series: drivers/base: use a worker for sysfs unbind (rev2)
URL : https://patchwork.freedesktop.org/series/53734/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ae9ec5f5e6bb drivers/base: use a worker for sysfs unbind
-:93: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <***@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 51 lines checked
Patchwork
2018-12-07 17:36:01 UTC
Permalink
== Series Details ==

Series: drivers/base: use a worker for sysfs unbind (rev2)
URL : https://patchwork.freedesktop.org/series/53734/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5288 -> Patchwork_11052
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_11052 absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_11052, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53734/revisions/2/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_11052:

### IGT changes ###

#### Possible regressions ####

* ***@i915_module_load@reload-no-display:
- fi-skl-6700hq: PASS -> INCOMPLETE
- fi-skl-6700k2: PASS -> INCOMPLETE
- fi-skl-iommu: PASS -> INCOMPLETE
- fi-kbl-7560u: PASS -> INCOMPLETE
- fi-pnv-d510: NOTRUN -> INCOMPLETE
- fi-whl-u: PASS -> INCOMPLETE
- fi-bwr-2160: PASS -> INCOMPLETE
- fi-kbl-r: PASS -> INCOMPLETE
- fi-blb-e6850: PASS -> INCOMPLETE
- {fi-kbl-7567u}: PASS -> INCOMPLETE
- fi-skl-6260u: PASS -> INCOMPLETE
- fi-snb-2600: PASS -> INCOMPLETE
- fi-hsw-peppy: PASS -> INCOMPLETE
- {fi-icl-u3}: NOTRUN -> INCOMPLETE
- fi-ilk-650: PASS -> INCOMPLETE
- fi-skl-6770hq: PASS -> INCOMPLETE
- fi-cfl-guc: PASS -> INCOMPLETE
- fi-ivb-3770: PASS -> INCOMPLETE
- fi-snb-2520m: PASS -> INCOMPLETE
- fi-cfl-8700k: PASS -> INCOMPLETE
- {fi-kbl-7500u}: PASS -> INCOMPLETE
- fi-ivb-3520m: PASS -> INCOMPLETE
- fi-hsw-4770: PASS -> INCOMPLETE
- fi-kbl-guc: PASS -> INCOMPLETE
- fi-skl-guc: PASS -> INCOMPLETE
- fi-bdw-5557u: PASS -> INCOMPLETE
- fi-cfl-8109u: NOTRUN -> INCOMPLETE
- fi-hsw-4770r: PASS -> INCOMPLETE

* {***@runner@aborted}:
- fi-ilk-650: NOTRUN -> FAIL
- fi-pnv-d510: NOTRUN -> FAIL
- fi-cfl-8109u: NOTRUN -> FAIL
- fi-hsw-peppy: NOTRUN -> FAIL
- fi-glk-dsi: NOTRUN -> FAIL
- fi-snb-2520m: NOTRUN -> FAIL
- fi-hsw-4770: NOTRUN -> FAIL
- {fi-kbl-7500u}: NOTRUN -> FAIL
- fi-skl-6700hq: NOTRUN -> FAIL
- fi-ivb-3770: NOTRUN -> FAIL
- fi-kbl-7560u: NOTRUN -> FAIL
- fi-bxt-dsi: NOTRUN -> FAIL
- fi-byt-j1900: NOTRUN -> FAIL
- fi-skl-iommu: NOTRUN -> FAIL
- fi-cfl-guc: NOTRUN -> FAIL
- fi-skl-guc: NOTRUN -> FAIL
- fi-bsw-n3050: NOTRUN -> FAIL
- fi-cfl-8700k: NOTRUN -> FAIL
- fi-kbl-8809g: NOTRUN -> FAIL
- fi-apl-guc: NOTRUN -> FAIL
- fi-kbl-r: NOTRUN -> FAIL
- fi-bdw-5557u: NOTRUN -> FAIL
- fi-bwr-2160: NOTRUN -> FAIL
- fi-skl-6770hq: NOTRUN -> FAIL
- fi-kbl-guc: NOTRUN -> FAIL
- fi-ivb-3520m: NOTRUN -> FAIL
- fi-snb-2600: NOTRUN -> FAIL
- fi-skl-6260u: NOTRUN -> FAIL


Known issues
------------

Here are the changes found in Patchwork_11052 that come from known issues:

### IGT changes ###

#### Issues hit ####

* ***@i915_module_load@reload-no-display:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927]
- fi-byt-j1900: PASS -> INCOMPLETE [fdo#102657]
- fi-skl-6600u: PASS -> INCOMPLETE [fdo#104108]
- fi-kbl-8809g: PASS -> INCOMPLETE [fdo#103665]
- fi-glk-j4005: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
- fi-bsw-n3050: PASS -> INCOMPLETE [fdo#105876]
- fi-byt-n2820: PASS -> INCOMPLETE [fdo#102657]
- fi-bxt-j4205: PASS -> INCOMPLETE [fdo#103927]
- fi-bxt-dsi: PASS -> INCOMPLETE [fdo#103927]
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]


#### Possible fixes ####

* ***@gem_ctx_create@basic-files:
- fi-bsw-n3050: FAIL [fdo#108656] -> PASS

* ***@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: DMESG-WARN [fdo#102614] -> PASS

* ***@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- fi-cfl-8109u: INCOMPLETE [fdo#106070] / [fdo#108126] -> PASS


#### Warnings ####

* ***@kms_chamelium@common-hpd-after-suspend:
- {fi-kbl-7567u}: DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602] -> DMESG-FAIL [fdo#105079]


{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#108126]: https://bugs.freedesktop.org/show_bug.cgi?id=108126
[fdo#108656]: https://bugs.freedesktop.org/show_bug.cgi?id=108656
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (50 -> 45)
------------------------------

Additional (2): fi-icl-u3 fi-pnv-d510
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y


Build changes
-------------

* Linux: CI_DRM_5288 -> Patchwork_11052

CI_DRM_5288: cf6669d4c0e52b024d8aea90fbe2c80841e67e59 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4743: edb2db2cf2b6665d7ba3fa9117263302f6307a4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11052: ae9ec5f5e6bb8895c23d9229d262f90a8702a3d7 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

ae9ec5f5e6bb drivers/base: use a worker for sysfs unbind

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11052/
Patchwork
2018-12-09 22:05:55 UTC
Permalink
== Series Details ==

Series: drivers/base: use a worker for sysfs unbind (rev3)
URL : https://patchwork.freedesktop.org/series/53734/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e6e8351e1d29 drivers/base: use a worker for sysfs unbind
-:105: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <***@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 57 lines checked
Patchwork
2018-12-09 22:27:18 UTC
Permalink
== Series Details ==

Series: drivers/base: use a worker for sysfs unbind (rev3)
URL : https://patchwork.freedesktop.org/series/53734/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5291 -> Patchwork_11054
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53734/revisions/3/mbox/

Known issues
------------

Here are the changes found in Patchwork_11054 that come from known issues:

### IGT changes ###

#### Issues hit ####

* ***@gem_ctx_create@basic-files:
- fi-bsw-n3050: PASS -> FAIL [fdo#108656]
- fi-bsw-kefka: PASS -> FAIL [fdo#108656]

* ***@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#108622]


#### Possible fixes ####

* ***@gem_exec_suspend@basic-s4-devices:
- fi-ivb-3520m: FAIL [fdo#108880] -> PASS


[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#108656]: https://bugs.freedesktop.org/show_bug.cgi?id=108656
[fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880


Participating hosts (51 -> 43)
------------------------------

Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-kbl-7560u


Build changes
-------------

* Linux: CI_DRM_5291 -> Patchwork_11054

CI_DRM_5291: 9bb72982ee481a5ae4da600e270d87c8416525a7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4743: edb2db2cf2b6665d7ba3fa9117263302f6307a4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11054: e6e8351e1d29ef97ac018b821e7c4bb9327e9ca5 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

e6e8351e1d29 drivers/base: use a worker for sysfs unbind

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11054/
Patchwork
2018-12-09 23:34:22 UTC
Permalink
== Series Details ==

Series: drivers/base: use a worker for sysfs unbind (rev3)
URL : https://patchwork.freedesktop.org/series/53734/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5291_full -> Patchwork_11054_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.



Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_11054_full:

### IGT changes ###

#### Possible regressions ####

* ***@i915_selftest@live_hangcheck:
- {shard-iclb}: PASS -> DMESG-FAIL


Known issues
------------

Here are the changes found in Patchwork_11054_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* ***@gem_exec_schedule@pi-ringfull-bsd:
- shard-skl: NOTRUN -> FAIL [fdo#103158]

* ***@gem_exec_suspend@basic-s3:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]

* ***@i915_suspend@shrink:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#108784]

* ***@kms_available_modes_crc@available_mode_test_crc:
- {shard-iclb}: NOTRUN -> FAIL [fdo#106641]

* ***@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: PASS -> DMESG-WARN [fdo#107956]

* ***@kms_chv_cursor_fail@pipe-c-128x128-left-edge:
- shard-skl: NOTRUN -> FAIL [fdo#104671]

* ***@kms_cursor_crc@cursor-128x128-onscreen:
- shard-skl: NOTRUN -> FAIL [fdo#103232]

* ***@kms_cursor_crc@cursor-256x85-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +1

* ***@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled:
- shard-skl: PASS -> FAIL [fdo#108472]

* ***@kms_fbcon_fbt@psr-suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107882]

* ***@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363]

* ***@kms_flip@flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363]

* ***@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167]
- shard-glk: PASS -> FAIL [fdo#103167] +1

* ***@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt:
- {shard-iclb}: PASS -> FAIL [fdo#103167] +2

* ***@kms_plane@pixel-format-pipe-b-planes:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]

* ***@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1

* ***@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815]

* ***@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166] +2

* ***@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +1

* ***@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- {shard-iclb}: PASS -> FAIL [fdo#103166]

* ***@kms_properties@connector-properties-atomic:
- shard-skl: NOTRUN -> FAIL [fdo#108642]

* {***@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-apl: PASS -> DMESG-FAIL [fdo#108950]

* ***@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]


#### Possible fixes ####

* ***@debugfs_test@read_all_entries_display_off:
- shard-skl: INCOMPLETE [fdo#104108] -> PASS

* ***@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS

* ***@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-glk: DMESG-WARN [fdo#107956] -> PASS

* ***@kms_chv_cursor_fail@pipe-b-256x256-bottom-edge:
- shard-skl: FAIL [fdo#104671] -> PASS

* ***@kms_color@pipe-b-ctm-green-to-red:
- shard-skl: FAIL [fdo#107201] -> PASS

* ***@kms_cursor_crc@cursor-256x256-dpms:
- shard-glk: FAIL [fdo#103232] -> PASS

* ***@kms_cursor_crc@cursor-64x21-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS

* ***@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS

* ***@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled:
- {shard-iclb}: WARN [fdo#108336] -> PASS

* ***@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-wc:
- {shard-iclb}: DMESG-FAIL [fdo#107724] -> PASS

* ***@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS

* ***@kms_frontbuffer_tracking@fbc-stridechange:
- {shard-iclb}: FAIL [fdo#103167] -> PASS

* ***@kms_plane@pixel-format-pipe-c-planes:
- shard-glk: FAIL [fdo#103166] -> PASS

* {***@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-apl: FAIL [fdo#108948] -> PASS

* ***@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: FAIL [fdo#108145] -> PASS

* ***@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS

* ***@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS

* {***@kms_rotation_crc@multiplane-rotation-cropping-top}:
- {shard-iclb}: DMESG-WARN [fdo#107724] -> PASS +6
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS

* ***@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
- {shard-iclb}: INCOMPLETE [fdo#107713] -> PASS

* ***@pm_rpm@fences:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS +1


#### Warnings ####

* ***@i915_suspend@shrink:
- shard-snb: DMESG-WARN [fdo#108784] -> INCOMPLETE [fdo#105411] / [fdo#106886]

* ***@kms_cursor_crc@cursor-64x64-suspend:
- {shard-iclb}: DMESG-FAIL [fdo#103232] / [fdo#107724] -> FAIL [fdo#103232]

* ***@kms_plane_multiple@atomic-pipe-b-tiling-x:
- {shard-iclb}: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103166]

* {***@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-kbl: DMESG-WARN [fdo#105604] -> DMESG-FAIL [fdo#108950]


{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108642]: https://bugs.freedesktop.org/show_bug.cgi?id=108642
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts


Build changes
-------------

* Linux: CI_DRM_5291 -> Patchwork_11054

CI_DRM_5291: 9bb72982ee481a5ae4da600e270d87c8416525a7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4743: edb2db2cf2b6665d7ba3fa9117263302f6307a4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11054: e6e8351e1d29ef97ac018b821e7c4bb9327e9ca5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11054/
Continue reading on narkive:
Loading...