[Intel-gfx] [PATCH] drm/i915/icl: Skip DSI path in DDI vswing programming.

Discussion:

Dhinakaran Pandiyan

2018-12-06 23:43:55 UTC

DSI implements it's own pre_enable hook, encoder output type is never
DSI.

Cc: Manasi Navare <***@intel.com>
Cc: Paulo Zanoni <***@intel.com>
Cc: James Ausmus <***@intel.com>
Fixes: fb5c8e9d4350 ("drm/i915/icl: Implement voltage swing programming sequence for Combo PHY DDI")
Signed-off-by: Dhinakaran Pandiyan <***@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index f3e1d6a0b7dd..5792632fa6a3 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2489,13 +2489,8 @@ static void icl_ddi_combo_vswing_program(struct drm_i915_private *dev_priv,
/* Set DisableTap2 and DisableTap3 if MIPI DSI
* Clear DisableTap2 and DisableTap3 for all other Ports
*/
- if (type == INTEL_OUTPUT_DSI) {
- val |= TAP2_DISABLE;
- val |= TAP3_DISABLE;
- } else {
- val &= ~TAP2_DISABLE;
- val &= ~TAP3_DISABLE;
- }
+ val &= ~TAP2_DISABLE;
+ val &= ~TAP3_DISABLE;
I915_WRITE(ICL_PORT_TX_DW5_GRP(port), val);

/* Program PORT_TX_DW2 */

--
2.17.1

Patchwork

2018-12-07 00:19:27 UTC

Permalink

Patchwork

2018-12-07 13:12:57 UTC

Permalink

== Series Details ==

Series: drm/i915/icl: Skip DSI path in DDI vswing programming.
URL : https://patchwork.freedesktop.org/series/53703/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5279_full -> Patchwork_11040_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_11040_full:

### IGT changes ###

#### Possible regressions ####

* ***@perf@oa-exponents:
- {shard-iclb}: PASS -> FAIL

Known issues
------------

Here are the changes found in Patchwork_11040_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* ***@kms_atomic_transition@1x-modeset-transitions:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +9

* ***@kms_cursor_crc@cursor-256x256-dpms:
- shard-apl: PASS -> FAIL [fdo#103232] +1

* ***@kms_cursor_crc@cursor-256x256-sliding:
- {shard-iclb}: NOTRUN -> FAIL [fdo#103232]

* ***@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]

* ***@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: PASS -> FAIL [fdo#103167] +1

* ***@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- {shard-iclb}: PASS -> DMESG-FAIL [fdo#107724] +3

* ***@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
- {shard-iclb}: PASS -> FAIL [fdo#103167] +3

* ***@kms_plane@pixel-format-pipe-c-planes:
- {shard-iclb}: NOTRUN -> FAIL [fdo#103166]

* {***@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-apl: PASS -> FAIL [fdo#108948]

* ***@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +1

* ***@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166]
- {shard-iclb}: PASS -> FAIL [fdo#103166]
- shard-glk: PASS -> FAIL [fdo#103166]

* {***@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-kbl: PASS -> DMESG-FAIL [fdo#108950]

* ***@kms_universal_plane@universal-plane-pipe-b-sanity:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] +18

* ***@pm_rpm@fences-dpms:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#108654]

#### Possible fixes ####

* ***@kms_atomic@test_only:
- {shard-iclb}: DMESG-WARN [fdo#107724] -> PASS +22

* ***@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-glk: DMESG-WARN [fdo#107956] -> PASS

* ***@kms_cursor_crc@cursor-128x128-random:
- shard-apl: FAIL [fdo#103232] -> PASS

* ***@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-ytiled:
- {shard-iclb}: WARN [fdo#108336] -> PASS +3

* ***@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- {shard-iclb}: DMESG-FAIL [fdo#107724] -> PASS +10

* ***@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: FAIL [fdo#103167] -> PASS

* ***@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt:
- {shard-iclb}: FAIL [fdo#103167] -> PASS +1

* ***@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- {shard-iclb}: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +10

* {***@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
- shard-apl: FAIL [fdo#108948] -> PASS

* ***@kms_plane@pixel-format-pipe-c-planes:
- shard-glk: FAIL [fdo#103166] -> PASS

* ***@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- {shard-iclb}: INCOMPLETE [fdo#107713] -> PASS

* ***@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS

* ***@kms_plane_multiple@atomic-pipe-b-tiling-y:
- {shard-iclb}: FAIL [fdo#103166] -> PASS

* ***@pm_rpm@legacy-planes-dpms:
- {shard-iclb}: INCOMPLETE [fdo#108840] -> PASS

* ***@pm_rpm@modeset-non-lpsp-stress-no-wait:
- {shard-iclb}: INCOMPLETE [fdo#108840] -> SKIP

#### Warnings ####

* ***@kms_ccs@pipe-a-crc-primary-rotation-180:
- {shard-iclb}: FAIL [fdo#107725] -> DMESG-WARN [fdo#107724] / [fdo#108336]

* ***@kms_cursor_crc@cursor-256x85-onscreen:
- {shard-iclb}: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103232]

* ***@kms_cursor_crc@cursor-64x21-random:
- {shard-iclb}: FAIL [fdo#103232] -> DMESG-WARN [fdo#107724] / [fdo#108336] +1

* ***@kms_plane@pixel-format-pipe-a-planes:
- {shard-iclb}: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103166]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950

Participating hosts (7 -> 6)
------------------------------

Missing (1): shard-skl

Build changes
-------------

* Linux: CI_DRM_5279 -> Patchwork_11040

CI_DRM_5279: 8c3dbdac21ef5357bfa9b11da9b2bd1baedc4962 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4743: edb2db2cf2b6665d7ba3fa9117263302f6307a4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11040: b5376994d2435d80bf43b696070164c4cb00417e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11040/

Imre Deak

2018-12-07 14:07:31 UTC

Permalink

Hi DK,

Post by Dhinakaran Pandiyan
DSI implements it's own pre_enable hook, encoder output type is never
DSI.
Fixes: fb5c8e9d4350 ("drm/i915/icl: Implement voltage swing programming sequence for Combo PHY DDI")
---
drivers/gpu/drm/i915/intel_ddi.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index f3e1d6a0b7dd..5792632fa6a3 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2489,13 +2489,8 @@ static void icl_ddi_combo_vswing_program(struct drm_i915_private *dev_priv,
/* Set DisableTap2 and DisableTap3 if MIPI DSI
* Clear DisableTap2 and DisableTap3 for all other Ports
*/
- if (type == INTEL_OUTPUT_DSI) {
- val |= TAP2_DISABLE;
- val |= TAP3_DISABLE;
- } else {
- val &= ~TAP2_DISABLE;
- val &= ~TAP3_DISABLE;
- }
+ val &= ~TAP2_DISABLE;
+ val &= ~TAP3_DISABLE;

note that Clint's patch at
https://patchwork.freedesktop.org/patch/265848/
solves this as well. We could minimize the churn by applying only that.

Post by Dhinakaran Pandiyan
I915_WRITE(ICL_PORT_TX_DW5_GRP(port), val);
/* Program PORT_TX_DW2 */
--
2.17.1
_______________________________________________
Intel-gfx mailing list
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Dhinakaran Pandiyan

2018-12-07 18:29:41 UTC

Permalink

Post by Imre Deak
Hi DK,

Post by Dhinakaran Pandiyan
DSI implements it's own pre_enable hook, encoder output type is never
DSI.
Fixes: fb5c8e9d4350 ("drm/i915/icl: Implement voltage swing
programming sequence for Combo PHY DDI")
---
drivers/gpu/drm/i915/intel_ddi.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c
b/drivers/gpu/drm/i915/intel_ddi.c
index f3e1d6a0b7dd..5792632fa6a3 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2489,13 +2489,8 @@ static void
icl_ddi_combo_vswing_program(struct drm_i915_private *dev_priv,
/* Set DisableTap2 and DisableTap3 if MIPI DSI
* Clear DisableTap2 and DisableTap3 for all other Ports
*/
- if (type == INTEL_OUTPUT_DSI) {
- val |= TAP2_DISABLE;
- val |= TAP3_DISABLE;
- } else {
- val &= ~TAP2_DISABLE;
- val &= ~TAP3_DISABLE;
- }
+ val &= ~TAP2_DISABLE;
+ val &= ~TAP3_DISABLE;

note that Clint's patch at
https://patchwork.freedesktop.org/patch/265848/
solves this as well. We could minimize the churn by applying only that.

Absolutely. Thanks for pointing it out.

-DK

Post by Imre Deak